[Tuner] Expand tuning candidate logging feature #2666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2666 +/- ##
=======================================
Coverage ? 77.03%
=======================================
Files ? 291
Lines ? 28892
Branches ? 0
=======================================
Hits ? 22257
Misses ? 6635
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bangtianliu
reviewed
Nov 13, 2025
bangtianliu
reviewed
Nov 13, 2025
bangtianliu
reviewed
Nov 13, 2025
bangtianliu
reviewed
Nov 13, 2025
bangtianliu
reviewed
Nov 13, 2025
bangtianliu
reviewed
Nov 13, 2025
bangtianliu
reviewed
Nov 13, 2025
kuhar
reviewed
Nov 13, 2025
kuhar
reviewed
Nov 13, 2025
kuhar
reviewed
Nov 13, 2025
bangtianliu
reviewed
Nov 14, 2025
bangtianliu
reviewed
Nov 14, 2025
bangtianliu
reviewed
Nov 14, 2025
bangtianliu
reviewed
Nov 14, 2025
bangtianliu
reviewed
Nov 14, 2025
bangtianliu
approved these changes
Nov 17, 2025
kuhar
reviewed
Nov 18, 2025
Member
kuhar
left a comment
kuhar
left a comment
There was a problem hiding this comment.
Looks good overall, just a few minor comments
Co-authored-by: Jakub Kuderski <[email protected]>
kuhar
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR expands the logging function to support data analysis of the candidate search space and
candidate_orderingperformance evaluation.Tuner now records candidate info such as tuning knob configurations, position in benchmark queue, final result ranking, etc.
The collected tuning records will be exported to a CSV file under the tuning base folder.